Skip to content

Remove unimplemented searchbar from project view #15901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2021
Merged

Remove unimplemented searchbar from project view #15901

merged 2 commits into from
May 17, 2021

Conversation

noerw
Copy link
Member

@noerw noerw commented May 16, 2021

This came up in discord; there is no handler for the search params on a project, and it is unclear to me how this searchbar should behave. As a quickfix remove it.
The searchbar was probably added by copy/paste error

@noerw noerw added this to the 1.15.0 milestone May 16, 2021
@noerw noerw added the topic/ui Change the appearance of the Gitea UI label May 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2021 •
edited
Loading

Codecov Report

Merging #15901 (6785b23) into main (a32bfd8) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15901      +/-   ##
==========================================
- Coverage   44.01%   43.99%   -0.03%     
==========================================
  Files         681      681              
  Lines       82336    82336              
==========================================
- Hits        36237    36220      -17     
- Misses      40195    40211      +16     
- Partials     5904     5905       +1
Impacted Files Coverage Δ
modules/auth/openid/discovery_cache.go 10.52% <0.00%> (-89.48%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
services/pull/pull.go 43.37% <0.00%> (ø)
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32bfd8...6785b23. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2021
@6543 6543 merged commit ba76bd7 into go-gitea:main May 17, 2021
@6543 6543 deleted the remove-project-searchbar branch May 17, 2021 00:10
@lunny
Copy link
Member

lunny commented May 17, 2021

Please send backport to v1.14

@noerw noerw mentioned this pull request May 17, 2021
Merged
@noerw noerw added the backport/done All backports for this PR have been created label May 17, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@noerw @AbdulrhmnGhanem
remove unimplemented searchbar from project view (go-gitea#15901)
9712704
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@noerw @codecov-commenter @lunny @lafriks @6543 @GiteaBot